-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AttributeError with Python 3.8 #56
Comments
Our pyproject.toml should probably be updated to specify that we require Python 3.9. The function in question was introduced in Python 3.9. Is Python 3.8 support important to you (i.e. is it particularly valuable for us to find a way to rewrite that code to support Python 3.8)? FWIW RAPIDS now requires 3.9 which is probably why none of the devs are seeing this issue. |
@vyasr Python 3.8 isn't important to me, I mostly ran into this issue by accident as 3.8 is the default Python version my OS uses. Once I realized it was working in 3.10 but not 3.8 I went back to check the minimum version on pypi and noticed 3.8 was listed as the minimum. |
Cool. I've opened a PR to update the minimum required version. Thanks for the ping! |
🎉 This issue has been resolved in version 1.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.7.3](rapidsai/dependency-file-generator@v1.7.2...v1.7.3) (2023-12-13) ### Bug Fixes * Update required Python version ([#60](rapidsai/dependency-file-generator#60)) ([0a4dd95](rapidsai/dependency-file-generator@0a4dd95)), closes [#56](rapidsai/dependency-file-generator#56)
I get an AttributeError with Python 3.8, but not with 3.10.
Repro:
Error:
The text was updated successfully, but these errors were encountered: