feat: Add option to delete preexisting files created by dfg each run #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
vyasr
changed the title
|
Note: I have intentionally not modified the pre-commit hook to always include the |
ajschmidt8
approved these changes
Feb 23, 2023
src/rapids_dependency_file_generator/rapids_dependency_file_generator.py
Outdated
Show resolved
Hide resolved
…nerator.py Co-authored-by: AJ Schmidt <[email protected]>
ajschmidt8
pushed a commit
that referenced
this pull request
Feb 23, 2023
# [1.4.0](v1.3.1...v1.4.0) (2023-02-23) ### Features * Add option to delete preexisting files created by dfg each run ([#32](#32)) ([381a835](381a835)), closes [/github.com/rapidsai/gha-tools/blob/37f3946294647eadf5b60d8229ac396a4d913b59/tools/rapids-dependency-file-checker#L9-L15](https://github.com//github.com/rapidsai/gha-tools/blob/37f3946294647eadf5b60d8229ac396a4d913b59/tools/rapids-dependency-file-checker/issues/L9-L15)
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
difyrrwrzd
added a commit
to difyrrwrzd/dependency-file-generator
that referenced
this pull request
Aug 10, 2024
# [1.4.0](rapidsai/dependency-file-generator@v1.3.1...v1.4.0) (2023-02-23) ### Features * Add option to delete preexisting files created by dfg each run ([#32](rapidsai/dependency-file-generator#32)) ([10e5118](rapidsai/dependency-file-generator@10e5118)), closes [/github.com/rapidsai/gha-tools/blob/37f3946294647eadf5b60d8229ac396a4d913b59/tools/rapids-dependency-file-checker#L9-L15](https://github.com//github.com/rapidsai/gha-tools/blob/37f3946294647eadf5b60d8229ac396a4d913b59/tools/rapids-dependency-file-checker/issues/L9-L15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to request that dfg erase any files it previously created before generating new ones. This logic may be used to replace cleanup logic already present in the tests as well as logic currently embedded in the GHA tool currently running dfg. Moving this logic directly into dfg will allow us to use its pre-commit hook as the primary source of truth for how to run it, both locally and in CI.
Contributes to rapidsai/shared-workflows#46