WIP: add libcuml Python builds #442
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
commented
Jan 22, 2025
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "NVIDIA RAPIDS devcontainer build utilities", | |||
| "id": "rapids-build-utils", | |||
| "version": "25.2.6", | |||
| "version": "25.2.8", | |||
There was a problem hiding this comment.
Bumping by 2 versions in anticipation of #440 merging first.
TODO before merging: confirm this version bump is still right after merging in latest branch-25.02.
jameslamb
commented
Jan 22, 2025
Comment on lines
+150
to
+151
| # TODO(jameslamb): revert this before merging | ||
| git: {<<: *git_defaults, repo: cuml, upstream: jameslamb, tag: libcuml-wheels} |
There was a problem hiding this comment.
Suggested change
| # TODO(jameslamb): revert this before merging | |
| git: {<<: *git_defaults, repo: cuml, upstream: jameslamb, tag: libcuml-wheels} | |
| git: {<<: *git_defaults, repo: cuml} |
Revert before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#33
Adjusts
rapids-build-utilsmanifest for release 25.02 to account for the introduction of newlibcumlwheels (rapidsai/cuml#6199).Notes for Reviewers
This shouldn't be merged still pointing at my forks.
Plan: