libav codec options #608
Merged
libav codec options #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naushir
reviewed
Nov 22, 2023
|
@popsUlfr, would you be able to format the commit messages to <= 80 character width lines and add a Otherwise, we are good to merge this in! |
Yeah sure no problem, give me some time to do just that. I'll also add a note about the default codec options in the help. |
A new command line argument '--libav-video-codec-opts' makes it possible to specify libav codec options. e.g.: --libav-video-codec-opts "preset=ultrafast;profile=high;partitions=i8x8,i4x4" Available options can be queried using 'ffmpeg -h encoder=libx264' for libx264. Signed-off-by: Philipp Richter <[email protected]>
Test that we can create a raw h264 file using libav with libx264 and codec options correctly. Signed-off-by: Philipp Richter <[email protected]>
popsUlfr
force-pushed
the
libav-options
branch
from
0283b09 to
5120fe0
Compare
|
Alright, done. Is this OK with you @naushir ? |
Yup, all good now! I'll merge this once the tests have finished. Thanks for this useful bit of work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows for specifying libav codec options.
AV1 encoding example with maximum encoding speed and low_latency on:
HEVC encoding example with ultrafast preset and main profile:
H264 encoding example with the ultrafast preset, high profile and level 4.2:
I've moved
encoderOptionsGeneral()under the specific encoder settings so that they can be overridden on the command line.