encoder: output: Fix bug where network output was not routed through … #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (assuming we don't care about the test failure)! I suppose the more fundamental issue is that we used to use the "codec" to tell if we were using libav or not, but now that's no longer the case. Now we're using "is the h/w codec available", though I wonder slightly whether we'd do better to have an explicit and distinct "I'm using libav" flag somewhere. But that's only me thinking out loud for the slightly longer term, I'm happy to merge! |
…libav on Pi 5 If the --codec libav option is not set, and a network stream output is specified, the NetOutput class will be initialised together with libav and fail to work on a Pi 5. Fix this by ensuring if we are going to use libav, do not initialise the NetOutput class, and allow libav to handle the network output. Signed-off-by: Naushir Patuck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…libav on Pi 5
If the --codec libav option is not set, and a network stream output is specified, the NetOutput class will be initialised together with libav and fail to work on a Pi 5.
Fix this by ensuring if we are going to use libav, do not initialise the NetOutput class, and allow libav to handle the network output.