Upgrade bazel version to 4.2.1 #18996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update ci/travis/bazel.py to output "bazel aquery ..." result in --jsonproto format, so we don't have to do the complicated textproto to json conversion.
gjoliver
requested review from
edoakes,
ericl and
richardliaw
as code owners
|
oh, all tests pass, including the msvs one!! :) |
richardliaw
approved these changes
Sep 30, 2021
jjyao
pushed a commit
that referenced
this pull request
Oct 1, 2021
simon-mo
pushed a commit
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also while debugging this, I realized that we can directly ask "bazel aquery ..." to
output in --jsonproto format, so we don't have to do the complicated textproto to
json conversion in bazel.py.
Why are these changes needed?
Bazel 4.2.1 is required for supporting M1 build.
Related issue number
#16621
Checks
scripts/format.shto lint the changes in this PR.