-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build rules and patches for darwin_arm64 platform. #19037
Conversation
Let's see if the CI tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so excited for this to work
don't merge until the tests pass :) |
ripperoni, looks like we'll need some other changes? |
huh ... it's ok, we will get there 😮💨 |
huh, windows build is actually working now. the 2 tests failed are both timeouts that have been failing all day. |
I'm very interested in this PR and associated issue. Thank you guys for working on it. I am a TA in a course on RL and they will be using rllib for the project. We are hoping to plug up this gap to allow everyone to run it locally, even students with an M1 Mac. Is there any way I can help to this up and running? |
Thanks for the message Tony. This is already pretty much working. |
d21f2cf
to
a584eb4
Compare
Changes include: Update nelhage/rules_boost package from current version (08/5/2020) to 5/27/2021 version. Remove rules_boost-undefine-boost_fallthrough.patch, since BOOST_FALLTHROUGH seems to be defined now. Minor changes to rules_boost-windows-linkopts.patch to use default condition to add -lpthread flag for all platforms. Add darwin_arm64 config to BUILD files for lib civetweb pulled in via prometheu dependency.
boost/bind.hpp and global namespace placeholders are deprecated.
finally all green. I even fixed a bunch of deprecation warnings caused by boost/bind.hpp. |
Great work, really glad to see this! |
Changes include:
Update nelhage/rules_boost package from current version (08/5/2020) to 5/27/2021 version.
Remove rules_boost-undefine-boost_fallthrough.patch, since BOOST_FALLTHROUGH seems to be defined now.
Minor changes to rules_boost-windows-linkopts.patch to use default condition to add -lpthread flag for all platforms.
Add darwin_arm64 config to BUILD files for lib civetweb pulled in via prometheu dependency.
Why are these changes needed?
Build fixes for Apple M1 laptop.
Related issue number
#16621
Checks
scripts/format.sh
to lint the changes in this PR.