Fix tests for Laravel 9 #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## feat-laravel9 #421 +/- ##
===================================================
- Coverage 68.48% 68.36% -0.13%
- Complexity 241 242 +1
===================================================
Files 34 34
Lines 787 787
===================================================
- Hits 539 538 -1
- Misses 248 249 +1
Continue to review full report at Codecov.
|
mbardelmeijer
commented
Feb 9, 2022
| @@ -32,8 +32,7 @@ public function tearDown(): void | |||
| */ | |||
| protected function getApplication(array $customConfig = []) | |||
| { | |||
| $app = new Application; | |||
| $app->instance('path', __DIR__); | |||
| $app = new Application(__DIR__); | |||
There was a problem hiding this comment.
This seems to have been the primary issue for the test failure of https://github.com/rcrowe/TwigBridge/pull/421/files#diff-04dfe553146326cf9741bd8fe61d5fccda3462627bd909cbf9798a4db6efc7eeR32
barryvdh
added a commit
that referenced
this pull request
Feb 10, 2022
* Fix tests for Laravel 9 (#421) * Set base path to Laravel application correctly Co-authored-by: Michel Bardelmeijer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.