Added LM_STATIC preprocessor flag when doing a static build

[Overhatted]

Simple PR to avoid adding "__declspec(dllexport)" to function declarations when creating a static library.

[Overhatted]

Yes, I've just pushed an update.

[rdbo]

Does it not work with LM_EXPORT defined in static builds?
My idea was either export or import, I'm not sure about having neither as an option

[luadebug]

Does it not work with LM_EXPORT defined in static builds? My idea was either export or import, I'm not sure about having neither as an option

afaik if defined & during MSVC windows build it will let you build LIB. if not defined it should let you build DLL on windows OS by MSVC toolchain.

[Overhatted]

It does work with __declspec(dllexport) when building static libraries. Not even sure what the consequences are or if the methods get exported if the .lib is linked into a .dll. I think the compiler creates some trampoline methods when dllexport is specified though.
Either way, all the projects I've used, used this approach of not adding anything when building a static library. For example:

1. https://github.com/freetype/freetype/blob/3f3e3de34ee3613d621b643c58a40b93148e0932/include/freetype/config/public-macros.h#L72
2. https://github.com/danoli3/FreeImage/blob/ebcb99952c6437f5e5afff52ad1a28664587782f/Source/FreeImage.h#L40
3. https://github.com/google/googletest/blob/d144031940543e15423a25ae5a8a74141044862f/googletest/include/gtest/internal/gtest-port.h#L874
4. https://github.com/libsdl-org/SDL/blob/d1af211010adb1030ce04860437fd5a580cf8eed/include/begin_code.h#L60

[Overhatted]

I don't understand these suggestions. Don't we want to add LM_STATIC only if "LIBMEM_BUILD_STATIC" is true?

[Overhatted]

For me, the ideal would be, for any OS:
StaticBuild: LM_STATIC
DynamicBuild: LM_EXPORT

It's also fine if we have LM_EXPORT all the time, like so:
StaticBuild: LM_STATIC and LM_EXPORT
DynamicBuild: LM_EXPORT

But the changes you suggested make it like this:
StaticBuild: LM_STATIC and LM_EXPORT
DynamicBuild: LM_STATIC and LM_EXPORT
So that it never adds the "__declspec(dllexport)" and so a dynamic library is never produced.

Or am I misunderstanding the changes?

[Overhatted]

Yes, it's fine, although unnecessary, to add LM_EXPORT during static builds since in the .h file, the "#ifdef LM_STATIC" comes first.

[Overhatted]

I've just added LM_EXPORT to both static and shared library. Seems like a good change that keeps backwards compatibility.

[luadebug]

Does it not work with LM_EXPORT defined in static builds?

Yes it works, this one is optimization targeted for Windows OS I guess. Dunno too problematic to push it without testing existing CI workflows that build libmem itself & Rust/Python3 bindings over different OS-es as well. Maybe bindings would need rework, but in case of OS-es it should be fine.

My idea was either export or import, I'm not sure about having neither as an option

Do you tend to keep only one define for this situation such as LM_EXPORT or LM_STATIC (This one keeps stuff relying over EXPORT defininition https://github.com/libsdl-org/SDL/blob/d1af211010adb1030ce04860437fd5a580cf8eed/include/begin_code.h#L60)?

Overall it looks good now.