fix Trim filter with null or other non-string value with strict_types=1 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmilash
changed the title
rdohms
requested changes
Oct 6, 2021
There was a problem hiding this comment.
Thanks @maxmilash !
Can you address the comments and add the context about the scenario to the commit message itself? (basically the text you added to the PR)
maxmilash
force-pushed
the
trim-php8-fix
branch
from
37e0ac5 to
e988334
Compare
|
Ok @rdohms. I fixed it |
rdohms
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using strict_type=1, if the value of the Trim filter gets null, or another value other than the string, then we will get Fatal Error, because trim accepts only a string.
Let's correct it, because I think this is erroneous behavior