New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change visibility from protected to private on final classes #51

Open

jeroenvdgulik wants to merge 1 commit into rdohms:v3-rewrite from jeroenvdgulik:v3-rewrite

jeroenvdgulik commented Oct 25, 2017

Makes no sense to have protected properties on final classes

Signed-off-by: Jeroen v.d. Gulik [email protected]


          Change visibility from protected to private on final classes

4add18b

Signed-off-by: Jeroen v.d. Gulik <[email protected]>

Owner

rdohms commented Oct 25, 2017

You sir are correct, not sure if i can keep your commit cause i will be rewriting most of the history on all that other PR.

but thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet