chore: bump ESLint and migrate to new config format #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
reviewed
Nov 22, 2023
krizzu
reviewed
Nov 22, 2023
krizzu
reviewed
Nov 22, 2023
tido64
force-pushed
the
tido/bump-eslint
branch
from
18126cc to
bfd03e9
Compare
krizzu
reviewed
Nov 23, 2023
| }, | ||
| }, | ||
| ...compat.config(wdio.configs.recommended), | ||
| ...compat.extends("plugin:@rnx-kit/recommended", "plugin:wdio/recommended"), |
There was a problem hiding this comment.
nit: Is there a way to separate those two actually? we only need WDIO in default-storage, so maybe we can extend our config with wdio there?
There was a problem hiding this comment.
This is a separate config file:
// packages/api/eslint.config.js
module.exports = require("@react-native-async-storage/eslint-config");
// packages/default-storage/eslint.config.js
module.exports = require("@react-native-async-storage/eslint-config/recommended-wdio");Edit: I was going to make recommended-wdio import from the default one, but it would require us to create two FlatCompat objects instead. Once this PR lands, I will come back and make this more obvious: microsoft/rnx-kit#2813
krizzu
approved these changes
Nov 24, 2023
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump ESLint and migrate to new config format
Test Plan
CI should pass.