Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Native v0.71.0 uses an outdated version of jsc-android (NDKs mismatch and causes crash) #178

Closed
kraenhansen opened this issue Feb 3, 2023 · 1 comment
Closed

React Native v0.71.0 uses an outdated version of jsc-android (NDKs mismatch and causes crash) #178

kraenhansen opened this issue Feb 3, 2023 · 1 comment

Comments

@kraenhansen
Copy link

Issue Description

As outlined in facebook/react-native#36052 there's a mismatch in NDK between the RN template app at v0.71.0 and the 250230.2.1 version of jsc-android. Upgrading React Native to use v294992.0.0 of jsc-android seems to relieve the issue, but this is not latest on NPM and marked as a pre-release on GitHub.

Another potential fix is to publish a release of 250230.2.1 build with an updated NDK, matching that of the RN template app.
@kraenhansen kraenhansen changed the title Current RN template app uses an outdated version of jsc-android React Native v0.71.0 uses an outdated version of jsc-android Feb 3, 2023
@kraenhansen kraenhansen changed the title React Native v0.71.0 uses an outdated version of jsc-android React Native v0.71.0 uses an outdated version of jsc-android (NDKs mismatch and causes crash) Feb 3, 2023
@kraenhansen kraenhansen mentioned this issue Feb 3, 2023
Closed
@Kudo Kudo mentioned this issue Feb 3, 2023
Merged
Kudo added a commit that referenced this issue Feb 5, 2023
@Kudo
feat: build with ndk r23c on top of webkitgtk 2.26.1 (#179)
61ac7a8 
# Why

fixes #178

# How

- manually pick necessary changes for ndk r23 from #169. it's ndk r23c which is newer than react-native 0.71's r23b. i cannot build jsc on top on r23b successfully. hopefully r23b <-> r23c is good for abi safety.
- fix build errors for webkitgtk 2.26.1 + ndk r23.
- unlike #169, this pr is still using shared c++ runtime.
- update test project to 0.71 and build from source code because we need a patch to link libunwind in libjscexecutor.so.

# Test Plan

ci passed
@Kudo
Copy link
Member

Kudo commented Feb 15, 2023

closed via #179

@Kudo Kudo closed this as completed Feb 15, 2023
Kudo added a commit to Kudo/jsc-android-buildscripts that referenced this issue Nov 16, 2024
@Kudo
feat: build with ndk r23c on top of webkitgtk 2.26.1 (react-native-co…
06ce9b7 
…mmunity#179)

# Why

fixes react-native-community#178

# How

- manually pick necessary changes for ndk r23 from react-native-community#169. it's ndk r23c which is newer than react-native 0.71's r23b. i cannot build jsc on top on r23b successfully. hopefully r23b <-> r23c is good for abi safety.
- fix build errors for webkitgtk 2.26.1 + ndk r23.
- unlike react-native-community#169, this pr is still using shared c++ runtime.
- update test project to 0.71 and build from source code because we need a patch to link libunwind in libjscexecutor.so.

# Test Plan

ci passed
Kudo added a commit that referenced this issue Nov 16, 2024
@Kudo
feat: build with ndk r23c on top of webkitgtk 2.26.1 (#179)
6b2fb7f 
# Why

fixes #178

# How

- manually pick necessary changes for ndk r23 from #169. it's ndk r23c which is newer than react-native 0.71's r23b. i cannot build jsc on top on r23b successfully. hopefully r23b <-> r23c is good for abi safety.
- fix build errors for webkitgtk 2.26.1 + ndk r23.
- unlike #169, this pr is still using shared c++ runtime.
- update test project to 0.71 and build from source code because we need a patch to link libunwind in libjscexecutor.so.

# Test Plan

ci passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kudo @kraenhansen