Update README.md for RN 0.59 instruction #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgindi
reviewed
Mar 22, 2019
| android { | ||
| // ... | ||
| + packagingOptions { | ||
| + pickFirst '**/libjsc.so' |
There was a problem hiding this comment.
Is libgnustl_shared.so not required anymore?
There was a problem hiding this comment.
Yes, both JSC and RN 0.59 is built by clang and have libc++_shared.so.
If there are libgnustl_shared.so duplicated error, it should NOT come from JSC and RN.
|
Close this due to the instruction for RN 0.60 may change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RN 0.59 packs JSC libraries in AAR, so that the instruction to add jsc-android is different than before.
Ths updated instruction puts jsc-android before RN dependency and use packagingOption.pickFirst to make sure gradle choose our JSC libraries.