Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added React Native version support table README.md #899

Merged
merged 5 commits into from
May 23, 2024

Conversation

JDMathew
Copy link
Contributor

Summary

I ran into build issues when installing this via storybook. It was unclear that the latest version of datetimepicker was not supported with older versions of react-native. I spent a while figuring this out though other issues and it would be good to include a version support table in the readme so others don't have to figure out backwards compatibility issues

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

README.md Outdated Show resolved Hide resolved
Copy link
Member

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your PR! Can you fix the small stuff (see comment)

@JDMathew
Copy link
Contributor Author

JDMathew commented May 23, 2024

thank you for your PR! Can you fix the small stuff (see comment)

@vonovak, I have updated the PR, let me know if there is anything else.

@vonovak
Copy link
Member

vonovak commented May 23, 2024

@JDMathew the table still mentions RN 0.7.0 which probably should be 0.70.0?

@JDMathew
Copy link
Contributor Author

@JDMathew the table still mentions RN 0.7.0 which probably should be 0.70.0?

Ah yes, sorry about that @vonovak, I updated 152 and missed 153. Should be correct now

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vonovak vonovak enabled auto-merge (squash) May 23, 2024 12:28
@JDMathew JDMathew requested a review from vonovak May 23, 2024 17:51
@vonovak vonovak merged commit da55211 into react-native-datetimepicker:master May 23, 2024
5 checks passed
@JDMathew JDMathew deleted the patch-1 branch May 30, 2024 01:52
@vonovak
Copy link
Member

vonovak commented Jun 3, 2024

🎉 This issue has been resolved in version 8.1.0 🎉

If this package helps you, consider sponsoring us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants