iOS: Use official method to get root view controller #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way of obtaining the root view controller appears to not be working in RN 0.59.10. This new approach uses an official [method](https://github.com/facebook/react-native/blob/91681016e84cdb99bd823c937762a0d9974e56fe/React/Base/RCTUtils.h#L87) provided by React Native.
|
Is it still the case with latest RN? |
|
I tested on the latest RN 0.61.4 and this works for me. Not only that, because I'm using "react-native-navigation" this is required in order for the document picker to display. |
|
@NichoCM yep, I believe (don't remember at the moment) that we're running into the same issue and we also use |
xubmuajkub
added a commit
to xubmuajkub/react-native-document-picker
that referenced
this pull request
Dec 11, 2019
…uments#230 Signed-off-by: rajivshah3 <https://github.com/rajivshah3>
|
thanks for the PR! (the RCTPresentedViewController impl isn't much different from the old one anyway https://github.com/facebook/react-native/blob/5ebca708132be8720c28a565e03b04e1087326cf/React/Base/RCTUtils.m#L506) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of obtaining the root view controller appears to not be working in RN 0.59.10. This new approach uses an official method provided by React Native.