-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mac os support #612
base: master
Are you sure you want to change the base?
mac os support #612
Conversation
can anyone test this one in ios, because i currently don't have a stable ios build of my app I have tested only on mac os |
@chriscarex thank you so much, next I'am gonna add support for the web with a new merge request |
hello and thanks for the PR |
@vonovak cool thanks |
@vonovak if anything worries you about my pr please write the changes i should make and dont close the pr, I will make the changes because i'am building my open source project on top of your stuff and i would like it to be used properly as you intended and i'am open to code style changes for sure, especially linting |
Hello and thank you for your PR! Sorry for taking so long to get back to you. First, how can I test this in the example app? Does this use Mac catalyst? Is it intended for react-native-macos? Thank you |
I am actively developing a react-native-macos application and would be willing to be a test dummy for this. Can we get the PR merged up to latest and I can give it a go in my project? |
Hi, |
I also have a use case for this in my react-native-macos app. Any chance we can get this merged? |
Might be good to recheck, but it sounds good |
Summary
OSX support is critical for my product
Test Plan
tested on OSX
What's required for testing (prerequisites)?
use base functionality
What are the steps to reproduce (after prerequisites)?
use base functionality
Compatibility
Checklist
README.md