Add Overlay onPress event for Android #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ❤️ Question: do we have this for iOS already? i not can be implemented for platform parity? |
|
@rborn as far as I saw it's not implemented for iOS. I gave it a quick try, but I'm so not into iOS stuff |
formatlos
force-pushed
the
overlay-press-event
branch
from
c062bf4
to
444ed61
Compare
alvelig
approved these changes
Aug 14, 2019
|
Really thanks for this ❤️ Exited to see it in the next release |
netmaxt3r
pushed a commit
to netmaxt3r/react-native-maps
that referenced
this pull request
Oct 6, 2019
* commit '3ae31e4a336102538ee422a0d4e71a2ea32647bb': (24 commits) [0.26.1] Release rn 0.60.5 support (react-native-maps#3020) "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103) [0.26.0] Release Add Heatmap back in (react-native-maps#3064) Fixes NPE while removing already removed marker. (react-native-maps#3032) Add flat property binding on Marker for iOS (react-native-maps#3051) Add heading to the onUserLocationChange listener (react-native-maps#3045) Add onDoublePress callback (react-native-maps#2937) Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935) updating pods for compile error (react-native-maps#3011) add overlay onPress event (react-native-maps#3007) Fix playServicesVersion name in installation docs (react-native-maps#3016) Update index.d.ts (react-native-maps#2887) Add @ReactModule annotation to help turbomodules processor (react-native-maps#3001) Google Maps - Heatmaps for Android and iOS (react-native-maps#2960) Added GeoJSON support by default (react-native-maps#2959) Update GoogleMaps pos to 3.2.0 (react-native-maps#2999) convert to new react native config format (RN 0.60 (react-native-maps#2975) fix select annotation when show/hide callout view (react-native-maps#2973) ... # Conflicts: # package.json
yuheidapperapps
added a commit
to yuheidapperapps/react-native-maps
that referenced
this pull request
Oct 15, 2019
* master: (31 commits) Wider Note column (prevent horisontal scroll) (react-native-maps#3130) replaced deprecated bridge.imageLoader calls with moduleForClass API (react-native-maps#3125) Implement onUserLocationChange in AIRMap (react-native-maps#2889) keep current mapType when taking snapshot (react-native-maps#3120) Add mapPadding on iOS maps (react-native-maps#3119) [iOS] Expose isAccessibilityElement as a prop (react-native-maps#3115) Add supportLibVersion safeguard in gradle build (react-native-maps#3106) [0.26.1] Release rn 0.60.5 support (react-native-maps#3020) "AIRMap" was not found in the UIManager IN "0.26.0" (react-native-maps#3103) [0.26.0] Release Add Heatmap back in (react-native-maps#3064) Fixes NPE while removing already removed marker. (react-native-maps#3032) Add flat property binding on Marker for iOS (react-native-maps#3051) Add heading to the onUserLocationChange listener (react-native-maps#3045) Add onDoublePress callback (react-native-maps#2937) Allow using onPanDrag while scrollEnabled=true (react-native-maps#2935) updating pods for compile error (react-native-maps#3011) add overlay onPress event (react-native-maps#3007) Fix playServicesVersion name in installation docs (react-native-maps#3016) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Adds
onPresscallback andtappableprop toOverlayon Android.Fixes the issue that the MapView onPress events are getting swallowed by Overlays.
How did you test this PR?
Tested with emulator and physical device on Android.
Add onPress callback handlers to the overlay and the MapView.
With
tappablesettruethe callback of the overlay fires as expected. Withtappablesetfalsethe callback of the MapView fires.