Feature: GeoJSON Marker Title Prop & A bit Refactor #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christopherdro, Actually I could not find the linter error. Can you help me to find it to pass from CI. |
|
@WrathChaos please update the docs and types for this new props. I’ll take a closer look at the error on CI |
|
@christopherdro, |
|
@christopherdro Done :) |
christopherdro
force-pushed
the
Feature/GeoJSONTitle
branch
from
830b91b
to
11d38a7
Compare
|
@WrathChaos I made a mistake while trying to fix the lint errors. Can you push force push your changes on branch |
WrathChaos
force-pushed
the
Feature/GeoJSONTitle
branch
from
11d38a7
to
4e310e3
Compare
|
@christopherdro Done |
christopherdro
force-pushed
the
Feature/GeoJSONTitle
branch
from
4e310e3
to
eb91424
Compare
|
@christopherdro When do you think this and the other PR's will be on live? |
|
@WrathChaos Can't say for sure right now, but one option is to point to your fork and create a branch with whatever changes you want on top of the latest stable release. |
borjomemost
pushed a commit
to borjomemost/react-native-maps
that referenced
this pull request
May 6, 2022
…s#3965) * new: PropType is added for title prop * new: PropType is added for title prop * new: tappable prop has the PropType description * fix: tappable crash is fixed * fix: Better description for title prop * new: GeoJSON doc is updated * new: types are added for geojson on index.t.ts * Fix lint * cleanup Co-authored-by: Christopher Dro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No other PR has the same thing
What issue is this PR fixing?
No issue right there, directly a fix and a new feature.
How did you test this PR?
Tested on both iOS and Android with both simulators and real devices.
What to do
New Feature
GeoJSONhas the new prop option:titlewhich shows a defaultCalloutwith the title.