Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: correct the update message. Closes #62" #159

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Revert "fix: correct the update message. Closes #62" #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
decb8be
Revert "fix: correct the update message. Closes #62"
brent-hoover Oct 25, 2022
32558f9
fix: fix lint errors from another PR
brent-hoover Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions commands/create-project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ const extraDependencyMap = {
* @summary creates api, admin, and storefront projects at same time in separate directories.
* @param {String} projectName - The name of the project to create
* @param {Object} options - Project options
* @returns {Boolean} true if success
*/
export async function createProjectAll(projectName, options) {
createProjectApi(projectName + "Api", options);
createProjectAdmin(projectName + "Admin", options);
createProjectStorefront(projectName + "Storefront", options);
createProjectApi(`${projectName}Api`, options);
createProjectAdmin(`${projectName}Admin`, options);
createProjectStorefront(`${projectName}Storefront`, options);
return true;
}

Expand Down
4 changes: 1 addition & 3 deletions utils/checkForNewVersion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,5 @@ const pkg = require("../package.json");
*/
export default async function checkForNewVersion() {
const notifier = updateNotifier({ pkg });
const updateCommand = "npm i -g reaction-cli";
const updateMessage = `Run ${updateCommand} to update.`;
notifier.notify({ message: updateMessage });
notifier.notify();
}