Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade NextJS to v9.3.3 #664

Closed
wants to merge 6 commits into from
Closed

refactor: upgrade NextJS to v9.3.3 #664

wants to merge 6 commits into from

Conversation

willopez
Copy link
Member

@willopez willopez commented Mar 31, 2020 •
edited
Loading

Impact: minor
Type: refactor|docs|chore

Issue

NextJS is outdated and causing some security vulnerabilities.

Solution

Upgrade to NextJS v9.3.3

Breaking changes

Images are now served from public directory and the static directory has been deprecated by Next.JS

Testing

  1. There should be no functional changes to the storefront, everything should works an before, rendering products, adding products to cart and checking out.

@willopez willopez mentioned this pull request Mar 31, 2020
Closed
@willopez willopez self-assigned this Mar 31, 2020
@willopez willopez requested a review from mikemurray April 1, 2020 18:42
@willopez willopez marked this pull request as ready for review April 1, 2020 18:43
@willopez willopez mentioned this pull request Apr 1, 2020
Closed
@willopez
Copy link
Member Author

willopez commented Jun 4, 2020

closing in favor of #667

@willopez willopez closed this Jun 4, 2020
@kieckhafer kieckhafer deleted the willopez-refactor-upgrade-nextjs branch September 21, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray Awaiting requested review from mikemurray

Assignees

@willopez willopez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@willopez