-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promotion Coupons #167
Promotion Coupons #167
Conversation
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
f4a40e1
to
7ecb805
Compare
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
@vannguyenn I'm getting the following error when trying to create a coupon:
Am i on a wrong branch of the API or something? |
@tedraykov yes, this PR is not ready for review yet. I'm waiting for some changes from the API |
Signed-off-by: Chloe <[email protected]>
Move to blocked while waiting for API changes from Brian |
@vannguyenn can you clarify what changes you are waiting for and that you are working against the coupons branch? |
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to improve error handling, specifically around duplicate codes and also currently it allows you to input an empty code or a code of all spaces. Also generally errors are not translating into usable feedback for the user
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
Signed-off-by: Chloe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have the issue with removing the coupon and then trying to create another one and it won't let you because the coupon has not been deleted but that needs to be fixed on the API side so approving with that one caveat. Error handling is much better.
Signed-off-by: Chloe <[email protected]>
@zenweasel I just integrated this PR with the delete coupon API. Please help to review the missing cases when you have time. Thanks |
Signed-off-by: Chloe <[email protected]>
Issue with deletion of coupon triggers resolved |
Resolves #142, #145, #144, #146
Testing Instructions:
feat/coupons
on API for testingCoupon is used (Standard)
option