Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion Coupons #167

Merged
merged 26 commits into from
Feb 20, 2023
Merged

Promotion Coupons #167

merged 26 commits into from
Feb 20, 2023

Conversation

vannguyenn
Copy link
Collaborator

@vannguyenn vannguyenn commented Jan 10, 2023

Resolves #142, #145, #144, #146

Testing Instructions:

  • Use branch feat/coupons on API for testing
  • Start the app and login with a valid account
  • Navigate to Promotions
  • Click on one promotion row to go to a Promotion details page
  • Scroll down to Promotion Builder section
  • Select trigger Coupon is used (Standard) option

Screenshot 2023-01-17 at 13 15 40

Screenshot 2023-01-17 at 13 16 12

Screenshot 2023-01-17 at 13 15 51

@vannguyenn vannguyenn changed the title Fix/promotion bugs Promotion Coupons Jan 10, 2023
@vannguyenn vannguyenn marked this pull request as ready for review January 17, 2023 06:16
@tedraykov
Copy link
Collaborator

@vannguyenn I'm getting the following error when trying to create a coupon:

Screenshot 2023-01-18 at 13 16 25

mutation.js:106 Error: canUseInStore is not allowed by the schema: {"response":{"errors":[{"message":"canUseInStore 
is not allowed by the schema","locations":[{"line":3,"column":3}],"path":["createPromotion"],"extensions":
{"code":"BAD_USER_INPUT","exception":{"errorType":"ClientError","name":"ClientError","error":"validation-error",
"details":[{"name":"canUseInStore","type":"keyNotInSchema","value":false,"message":"canUseInStore 
is not allowed by the schema"}],"stacktrace":["ClientError: canUseInStore is not allowed by the schema"

Am i on a wrong branch of the API or something?
I'm using the latest from feat/promotions

@vannguyenn
Copy link
Collaborator Author

@tedraykov yes, this PR is not ready for review yet. I'm waiting for some changes from the API

@vannguyenn vannguyenn self-assigned this Jan 30, 2023
@vannguyenn
Copy link
Collaborator Author

Move to blocked while waiting for API changes from Brian

@brent-hoover
Copy link
Collaborator

@vannguyenn can you clarify what changes you are waiting for and that you are working against the coupons branch?

Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to improve error handling, specifically around duplicate codes and also currently it allows you to input an empty code or a code of all spaces. Also generally errors are not translating into usable feedback for the user

Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have the issue with removing the coupon and then trying to create another one and it won't let you because the coupon has not been deleted but that needs to be fixed on the API side so approving with that one caveat. Error handling is much better.

@vannguyenn
Copy link
Collaborator Author

@zenweasel I just integrated this PR with the delete coupon API. Please help to review the missing cases when you have time. Thanks

@brent-hoover
Copy link
Collaborator

Issue with deletion of coupon triggers resolved

@vannguyenn vannguyenn merged commit dab5a45 into feat/promotion-coupons Feb 20, 2023
@vannguyenn vannguyenn deleted the fix/promotion-bugs branch February 20, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants