This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Migration to TypeScript #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Signed-off-by: tedraykov <[email protected]>
tedraykov
commented
Oct 2, 2021
|
|
||
| level = level.toUpperCase(); | ||
| const outputModes = ["short", "long", "simple", "json", "bunyan"]; | ||
| type OutputMode = "short" | "long" | "simple" | "json" | "bunyan"; |
There was a problem hiding this comment.
I'm doing this because Bunyan type definitions do not export the Options interface and if the outputMode here does not match the string literal type defined in the BunyanFormat options, the compiler gives a type check error when instantiating the default stream on line 29.
|
Using the new version of the Logger throws the following error: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
The current API is using vanilla JavaScript which lacks type checking.
Solution
A migration to TypeScript will provide a better development experience.
Testing