Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new inventoryStatus component #380

Merged
merged 7 commits into from
Dec 13, 2018

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Dec 7, 2018

Impact: minor
Type: feature

Component

This new component uses similar logic as that of BadgeOverlay to determine the inventory status of a product / variant / option, an return text related to that status.

This component uses the existing StockWarning component if the inventory status is isLowQuantity, otherwise it returns new text.

Screenshots

inventorystatus_ _reaction_design_system

inventorystatus_ _reaction_design_system

inventorystatus_ _reaction_design_system

Breaking changes

None.

Testing

  1. See that the message changes based on different isBackorder, isLowQuantity, and isSoldOut data.

@rc-publisher
Copy link
Collaborator

rc-publisher commented Dec 7, 2018

🚀 Preview deployed

Built with commit b3b5482

https://deploy-preview-380--stoic-hodgkin-c0179e.netlify.com

@kieckhafer kieckhafer changed the title [WIP] feat: add new inventoryStatus component feat: add new inventoryStatus component Dec 10, 2018
@kieckhafer
Copy link
Member Author

Please note that inventoryAvailableToSell will be added to the GraphQL endpoint in this PR: reactioncommerce/reaction#4859

Copy link
Contributor

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 props for adding specs for the utility functions!

@machikoyasuda machikoyasuda merged commit b234f72 into master Dec 13, 2018
@machikoyasuda machikoyasuda deleted the feat-kieckhafer-inventoryStatusComponent branch December 13, 2018 00:52
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 0.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants