Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweetAlert2 ^7.0.0 breaks existing pop up alerts #3379

Closed
kieckhafer opened this issue Dec 8, 2017 · 0 comments
Closed

sweetAlert2 ^7.0.0 breaks existing pop up alerts #3379

kieckhafer opened this issue Dec 8, 2017 · 0 comments
Assignees
@kieckhafer
Labels
bug For issues that describe a defect or regression in the released software

Comments

@kieckhafer
Copy link
Member

Expected behavior

Alerts.alert should do something when an alert window is confirmed, or cancelled

Actual behavior

Alerts.alert silently fails when either button is clicked

Steps to reproduce the behavior

  • Find any pop-up alert (for instance, deleting a picture from the PDP), and click either the cancel or confirm buttons
  • See the pop-up closes, but nothing happens

Versions

sweetAlert2 7.0.0+
@kieckhafer kieckhafer self-assigned this Dec 8, 2017
@kieckhafer kieckhafer mentioned this issue Dec 8, 2017
Merged
@brent-hoover brent-hoover mentioned this issue Dec 8, 2017
Closed
@brent-hoover brent-hoover added bug For issues that describe a defect or regression in the released software impact-critical labels Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kieckhafer kieckhafer

Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brent-hoover @kieckhafer @codejockie