Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): 3379 - sweetAlerts2 ^7.0.0 update compatibility #3380

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Dec 8, 2017

Fixes #3379

When we updated package.json, it bumped sweetAlerts2 to a ^7.0.0 version, which had breaking changes.

This PR follows their directions to add backwards compatibly to our Alerts.alert so the pop-up alerts continue to work as they did.

To Test:

  • Find any pop-up alert (for instance, deleting a picture from the PDP), and click either the cancel or confirm buttons
  • See that the action you select actually happens, instead of just closing the pop-up silently

@kieckhafer kieckhafer requested a review from mikemurray December 8, 2017 01:16
@spencern
Copy link
Contributor

spencern commented Dec 8, 2017

@kieckhafer how can I test this, what should I be looking for?

@kieckhafer
Copy link
Member Author

@spencern updated description with testing instructions. Basically all pop ups Alerts were just closing silently without actually doing what they were supposed to do. So just find a pop-up and make sure clicking the button does what it should instead of just closing the pop-up.

@duanhong169
Copy link
Contributor

Same issue and @kieckhafer 's fix works.

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@spencern spencern changed the base branch from master to release-1.6.1 December 12, 2017 00:21
@spencern spencern merged commit f8bc69c into release-1.6.1 Dec 12, 2017
@spencern spencern deleted the kieckhafer-bug-3379-sweetalertfix branch December 12, 2017 00:21
@spencern spencern mentioned this pull request Dec 12, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
…eetalertfix

(fix): 3379 - sweetAlerts2 ^7.0.0 update compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants