Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags: Backend - A Tag and its listing page can be marked as inactive and active #4848

Closed
machikoyasuda opened this issue Dec 4, 2018 · 0 comments
Closed

Tags: Backend - A Tag and its listing page can be marked as inactive and active #4848

machikoyasuda opened this issue Dec 4, 2018 · 0 comments
Milestone
🏔 Torreys

Comments

@machikoyasuda
Copy link
Contributor

machikoyasuda commented Dec 4, 2018 •
edited
Loading

  • An admin user can create a tag and a tag landing page that is not in the Nav, invisible to site maps and search engines. When a tag and its landing page are set as inactive, it should be invisible to site maps and search engines. Currently when an admin creates a tag, it automatically creates a route. We will no longer automatically create a route. A page has to be marked as active.

Front-end ticket for this feature: #4849
@machikoyasuda machikoyasuda mentioned this issue Dec 4, 2018
Closed
@machikoyasuda machikoyasuda changed the title Tags: Backend - A Tag and its landing page can be marked as inactive Tags: Backend - A Tag and its landing page can be marked as inactive and active Dec 4, 2018
@machikoyasuda machikoyasuda changed the title Tags: Backend - A Tag and its landing page can be marked as inactive and active Tags: Backend - A Tag and its listing page can be marked as inactive and active Dec 5, 2018
@machikoyasuda machikoyasuda added this to the 🏔 Shavano milestone Dec 10, 2018
This was referenced Dec 12, 2018
Closed
Merged
@machikoyasuda machikoyasuda modified the milestone: 🏔 Shavano Dec 18, 2018
mikemurray added a commit that referenced this issue Jan 2, 2019
@mikemurray
Merge pull request #4879 from reactioncommerce/4848-feat-machikoyasud…
0ee327d 
…a-only-return-isVisible-tags

feat(#4848) - Return only isVisible Tags, unless admin
@spencern spencern modified the milestones: 🏔 Shavano, 🏔 Torreys Jan 15, 2019
@spencern spencern mentioned this issue Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🏔 Torreys
Development

No branches or pull requests
2 participants
@spencern @machikoyasuda