Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 2270 Product Grid Double Click on Mobile #2315

Closed
wants to merge 4 commits into from
Closed

[WIP] 2270 Product Grid Double Click on Mobile #2315

wants to merge 4 commits into from

Conversation

abdulsemiu-atanda
Copy link
Contributor

@abdulsemiu-atanda abdulsemiu-atanda commented May 22, 2017 •
edited
Loading

Resolves #2270

Testing

  • Clone this branch and run on your local machine
  • Log In as an Admin and toggle Edit Mode ON
  • Reduce your browser size to less that 949px and open a new tab and visit localhost:3000
  • Double-click on any product
  • Observe that it takes you to the Product Detail Page

@abdulsemiu-atanda
Copy link
Contributor Author

@rymorgan I was able to fix #2270 by disabling Grid Settings overlay in viewports smaller than 949px as it was preventing a double click event from firing.

I would like to know if that behavior will be in line with our current design and if there are suggestions around improving it.

@abdulsemiu-atanda abdulsemiu-atanda mentioned this pull request May 22, 2017
Closed
@brent-hoover
Copy link
Collaborator

Closing this for now until the behavior is decided.

@brent-hoover brent-hoover deleted the atanda-product-grid-double-click-2270 branch May 26, 2017 01:44
@snyk-bot snyk-bot mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulsemiu-atanda @brent-hoover