Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsdoc: format Invoice React component into @module #3141

Merged
merged 3 commits into from
Oct 24, 2017
Merged

jsdoc: format Invoice React component into @module #3141

merged 3 commits into from
Oct 24, 2017

Conversation

machikoyasuda
Copy link
Contributor

What this PR does

  1. Add @module definition at the top of the file
  2. Add @type {propTypes}
  3. Add @name in front of the methods so they get rendered.

How it renders

screen shot 2017-10-19 at 4 23 49 pm

@aaronjudd
Copy link
Contributor

Feels like the components should be a higher level group, at the same level as "method". This might just be a styling issue?
invoice_-_documentation_and_reactioncommerce_reaction

@aaronjudd aaronjudd self-requested a review October 20, 2017 14:53
aaronjudd
aaronjudd suggested changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@aaronjudd aaronjudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that components are being grouped correctly. If so, I'm good to merge.

@aaronjudd aaronjudd merged commit 822fb0d into release-1.5.3 Oct 24, 2017
@impactmass impactmass mentioned this pull request Oct 24, 2017
Merged
@machikoyasuda machikoyasuda deleted the jsdoc-document-invoice-component branch October 25, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjudd aaronjudd aaronjudd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machikoyasuda @aaronjudd