-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace meteor/jparker:gravatar with our ReactionAvatar react component #3149
Merged
brent-hoover
merged 5 commits into
release-1.5.6
from
ek-replacemeteorGravatar-with-ReacdtionAvatar
Nov 2, 2017
Merged
replace meteor/jparker:gravatar with our ReactionAvatar react component #3149
brent-hoover
merged 5 commits into
release-1.5.6
from
ek-replacemeteorGravatar-with-ReacdtionAvatar
Nov 2, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get this error when starting up
|
brent-hoover
requested changes
Oct 25, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a console error on startup
@zenweasel updated to fix the error |
brent-hoover
approved these changes
Oct 31, 2017
brent-hoover
deleted the
ek-replacemeteorGravatar-with-ReacdtionAvatar
branch
November 2, 2017 21:44
Merged
Akarshit
pushed a commit
that referenced
this pull request
Jan 7, 2018
…ar-with-ReacdtionAvatar replace meteor/jparker:gravatar with our ReactionAvatar react component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2410
In our effort to move away from
meteor
packages, this update replacesmeteor/jparker:gravatar
withReactionAvatar
, our React version of Gravatars, throughout the app.Most of the app has already been done, so this PR specifically replaces the Gravatar's in the nav bar, and inside the Groups table (when logged in as an admin).