Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace meteor/jparker:gravatar with our ReactionAvatar react component #3149

Merged

Conversation

kieckhafer
Copy link
Member

Resolves #2410

In our effort to move away from meteor packages, this update replaces meteor/jparker:gravatar with ReactionAvatar, our React version of Gravatars, throughout the app.

Most of the app has already been done, so this PR specifically replaces the Gravatar's in the nav bar, and inside the Groups table (when logged in as an admin).

@brent-hoover
Copy link
Collaborator

I get this error when starting up

modules.js?hash=7ee907e6d17784321fe48b45f09bcaa0f5d0b366:85730 Warning: Failed prop type: Invalid prop `userImage` supplied to `Reaction(MainDropdown)`.
    in Reaction(MainDropdown) (created by Tracker(Reaction(MainDropdown)))
    in Tracker(Reaction(MainDropdown)) (created by withProps(Tracker(Reaction(MainDropdown))))
    in withProps(Tracker(Reaction(MainDropdown))) (created by Tracker(withProps(Tracker(Reaction(MainDropdown)))))
    in Tracker(withProps(Tracker(Reaction(MainDropdown)))) (created by Reaction(NavBar))
    in div (created by Reaction(NavBar))
    in Reaction(NavBar) (created by Tracker(Reaction(NavBar)))
    in Tracker(Reaction(NavBar)) (created by Reaction(coreLayout))
    in div (created by Reaction(coreLayout))
    in Reaction(coreLayout) (created by Route)
    in Route
    in Switch (created by Reaction(App))
    in div (created by Reaction(App))
    in Reaction(App) (created by Tracker(Reaction(App)))
    in Tracker(Reaction(App))
    in TranslationProvider (created by Tracker(TranslationProvider))
    in Tracker(TranslationProvider)
    in Router (created by BrowserRouter)
    in BrowserRouter

Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a console error on startup

@kieckhafer
Copy link
Member Author

@zenweasel updated to fix the error

@brent-hoover brent-hoover changed the base branch from master to release-1.5.6 November 2, 2017 21:44
@brent-hoover brent-hoover merged commit 79da3ed into release-1.5.6 Nov 2, 2017
@brent-hoover brent-hoover deleted the ek-replacemeteorGravatar-with-ReacdtionAvatar branch November 2, 2017 21:44
@brent-hoover brent-hoover mentioned this pull request Nov 2, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
…ar-with-ReacdtionAvatar

replace meteor/jparker:gravatar with our ReactionAvatar react component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants