Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS region for api publishing #3150

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Add AWS region for api publishing #3150

merged 2 commits into from
Oct 21, 2017

Conversation

aaronjudd
Copy link
Contributor

@aaronjudd aaronjudd commented Oct 21, 2017

  • While working w/o locally, region is needed on circleci
  • tested via ci ssh
  • adds API_DOC_BUCKET, API_DOC_BUCKET_REGION to env variables for CircleCI

While working w/o locally, is needed on circleci
@aaronjudd aaronjudd requested review from spencern and jshimko October 21, 2017 00:18
- API_DOC_BUCKET_REGION
@aaronjudd
Copy link
Contributor Author

aaronjudd commented Oct 21, 2017

@jshimko @spencern I believe this is good to merge direct to master. While aws s3 sync works locally, on CircleCI it needed region to be supplied as an option --region otherwise the command returns a warning. Updated both the bucket and region to be env variables as well. Tested via CI SSH.

@spencern
Copy link
Contributor

@aaronjudd how can I test this? Code looks good and makes sense, do we need to put ENV vars into CircleCI or do I supply them from my local?

@aaronjudd
Copy link
Contributor Author

Really only one way to truly test.

@aaronjudd aaronjudd merged commit d62967b into master Oct 21, 2017
@aaronjudd aaronjudd deleted the add-aws-region branch October 21, 2017 05:50
@impactmass impactmass mentioned this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants