Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdoc: add PropTypes namespace for PropType validating methods #3175

Merged
merged 4 commits into from
Nov 2, 2017

Conversation

machikoyasuda
Copy link
Contributor

What this PR does

  1. Adds PropType namespace
  2. Adds methods to this namespace

How that renders

screen shot 2017-10-25 at 3 26 36 pm

const TagSchema = Schemas.Tag.newContext();

export const PropTypes = {};

/**
* React Component propType validator for a single Tag
* @name Tag
* @summary React Component propType validator for a single Tag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should propType be PropType to match the @file description above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! fixed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 17 here it's still showing as propType to me

@machikoyasuda
Copy link
Contributor Author

Fixed again and updating master to 1.5.5

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brent-hoover brent-hoover changed the base branch from master to release-1.5.6 November 2, 2017 22:03
@brent-hoover brent-hoover merged commit 1f178c2 into release-1.5.6 Nov 2, 2017
@brent-hoover brent-hoover deleted the jsdoc-namespace-proptypes branch November 2, 2017 22:04
@brent-hoover brent-hoover mentioned this pull request Nov 2, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
jsdoc: add PropTypes namespace for PropType validating methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants