Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniqueItem._id undefined #3296

Conversation

codejockie
Copy link
Contributor

Resolves #3104

This PR fixes the a bug where uniqueItem._id is undefined when an order is made with Avalara enabled.

How to Test

  • Login as admin
  • Enable Shippo shipment method
  • Enable Stripe payment
  • Enable Avalara Tax calculations
  • Place an order
  • Go to the Order Dashboard
  • Click on the order you placed
  • Observe that the "Invoice" section is displayed just after the "Summary" section
  • Observe in the console that there's no error

Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed.

@spencern spencern changed the base branch from master to release-1.5.9 November 20, 2017 23:40
@spencern spencern merged commit 52e2c9e into release-1.5.9 Nov 20, 2017
@spencern spencern deleted the kennedy-fix-order-workflow-uniqueItem-_id-undefined-3104 branch November 20, 2017 23:41
@spencern spencern mentioned this pull request Nov 21, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
…flow-uniqueItem-_id-undefined-3104

Fix uniqueItem._id undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants