Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hide settings panels merchant shops #3299

Merged
merged 4 commits into from
Nov 20, 2017

Conversation

spencern
Copy link
Contributor

This PR hides the following settings panels from merchant type shops

  • Account settings (used for setting up OAuth login)
  • Analytics settings (used for connecting 3rd party analytics services)
  • Sms settings (used for connecting SMS services such as Twilio)

These settings panels contain settings that are meant for the primary shop and do not need to be visible at the merchant shop level.

To test:

  1. Invite a merchant shop
  2. Observe that the three settings panels listed above are not present in the merchant shop dashboard, but are still available on the primary shop dashboard.

This is a setting that I think merchant shops should have access to, but we need to build a multi-shop analytics integration that has capability to report to multiple analytics accounts first.
@spencern spencern requested a review from kieha November 16, 2017 00:47
Copy link
Contributor

@kieha kieha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 LGTM

@spencern spencern changed the base branch from master to release-1.5.9 November 20, 2017 23:39
@spencern spencern merged commit b644bf7 into release-1.5.9 Nov 20, 2017
@spencern spencern deleted the refactor-spencer-update-merchant-shop-apps branch November 20, 2017 23:39
@spencern spencern mentioned this pull request Nov 21, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
…e-merchant-shop-apps

Fix: hide settings panels merchant shops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants