Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email updated translation #3321

Merged
merged 3 commits into from
Dec 8, 2017
Merged

Conversation

iakhator
Copy link

@iakhator iakhator commented Nov 20, 2017

Resolve #3307

  • Added email updated translation
  • Whenever user try to update email it shows accountUI.info.emailUpdated instead of emailUpdated

Test

  • Login as Admin or User
  • Click profile to reveal the profile page.
  • Change email and click on update email address.
  • Notice the toastr message 'Email Updated'.

@brent-hoover
Copy link
Collaborator

@iakhator So it's not really testing instructions to tell me to just look at the code. Surely this must manifest in the UI somewhere right?

@iakhator
Copy link
Author

yes @zenweasel , this manifest when the user is updating the email. I will re-write the test instruction.

@iakhator
Copy link
Author

iakhator commented Nov 26, 2017

@zenweasel Test updated

Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed

@Akarshit
Copy link
Contributor

Akarshit commented Nov 30, 2017

@zenweasel Do you think that it makes sense that when adding a new i18n key we should translate it to all the languages we support and then add it.
So basically just use google translate(or some script) and add translations for all the languages.
Wouldn't this prevent a lot of xxxx is not translated for yyyy language issues?

@brent-hoover
Copy link
Collaborator

@Akarshit No, we use LingoHub which basically automates that process

@spencern spencern changed the base branch from master to release-1.6.1 December 8, 2017 22:47
@spencern spencern merged commit f475b25 into release-1.6.1 Dec 8, 2017
@spencern spencern deleted the update-email-translation branch December 8, 2017 22:48
@spencern spencern mentioned this pull request Dec 12, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants