-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email updated translation #3321
Conversation
@iakhator So it's not really testing instructions to tell me to just look at the code. Surely this must manifest in the UI somewhere right? |
yes @zenweasel , this manifest when the user is updating the email. I will re-write the test instruction. |
@zenweasel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Verified fixed
@zenweasel Do you think that it makes sense that when adding a new i18n key we should translate it to all the languages we support and then add it. |
@Akarshit No, we use LingoHub which basically automates that process |
Add email updated translation
Resolve #3307
accountUI.info.emailUpdated
instead ofemailUpdated
Test