Fix flash empty cart flashing when registering a user #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brent-hoover
approved these changes
Dec 6, 2017
Merged
Akarshit
pushed a commit
that referenced
this pull request
Jan 7, 2018
Fix flash empty cart flashing when registering a user
impactmass
reviewed
Jan 12, 2018
| }, | ||
| cartCount() { | ||
| const cart = Cart.findOne(); | ||
| if (cart.items && cart.items.length > 0) { |
There was a problem hiding this comment.
There is a brief time when cart doesn't exist (this happens when a cart is transitioned to an order and another cart is being created for the user). In that brief time, an error is thrown in the browser console by this line.
This line will be better as:
if (cart && cart.items && cart.items.length > 0) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #3036
This PR fix empty cart showing up while registering new user, The reason for the empty cart showing up is that the cart.items is empty at the that window it tries to register the user. What I did was to create a helper method in checkout.js called cartCount where it checks if the cart.item exists and also check if the length is greater than 0.
Test
empty cart page