(fix): 3392 - remove shopId check on payment methods for merchent orders #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieckhafer
changed the title
spencern
approved these changes
Dec 12, 2017
There was a problem hiding this comment.
These shopId checks seem redundant and can only really cause errors.
For Package.find.. we should either be looking for a package name + shopId or a package _id.
Looking for a package _id + shopId means that for all shopIds other than the shopId associated with the package _id that is used will fail to find a package.
|
@zenweasel will you look at this PR as well. I think you reviewed the PR that these lines came in from and I want to be sure that I'm not missing anything important. |
|
Yes, there's absolutely no reason to check for shopId if you are grabbing the package by packageId (like @spencern said). I feel pretty confident it was probably a copy and paste artifact. |
Merged
Akarshit
pushed a commit
that referenced
this pull request
Jan 7, 2018
…nneededShopIdCheck (fix): 3392 - remove shopId check on payment methods for merchent orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3392
An error was occurring when trying to process orders as a merchant shop, using a payment method that belonged to the marketplace owner shop.
The package was checking for a packageId && a shop ID, however the shop ID was the active shop, and the packageId belongs to the marketplace shop, so if you were a merchant processing an order, there would never be a match here, causing an error.
the packageIds are specific enough where we don't need this extra shopId check.