chore: update default GraphQL query limit values #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieckhafer
changed the title
kieckhafer
changed the title
aldeed
reviewed
Jun 5, 2018
| // Enforce a `first: 50` limit if no user-supplied limit | ||
| const limit = first || last || 50; | ||
| // Enforce a `first: 20` limit if no user-supplied limit | ||
| const limit = first || last || 20; |
There was a problem hiding this comment.
@kieckhafer Can you add const DEFAULT_LIMIT = 20; at the top of the file and use that const here? We'll eventually put this in ENV but that's at least a little less magic for now.
aldeed
reviewed
Jun 5, 2018
| @@ -7,13 +7,13 @@ beforeEach(() => { | |||
| }); | |||
|
|
|||
| test("with neither first nor last limits to first 50", async () => { | |||
There was a problem hiding this comment.
50 in the test name needs to change, too
|
@aldeed updated |
aldeed
approved these changes
Jun 5, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4278
Impact: minor
Type: chore
Issue
The query limits are not optimized on our GraphQL queries
Solution
Change default first value (when neither first nor last are provided by the client) to 20, to have a default that minimizes DB and server load
Change the max first and last values to 200
Breaking changes
none.
Testing
Test on at least one query that has > 205 items. For example, import > 205 tags or catalog items.