Fix #4502: null check in email validation #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2018 10:39
|
@pardyot I can't fast-forward to test your branch. Can you update to the latest |
|
Sure! |
…rdyot-email-validation
|
@zenweasel - Merged release-1.15.0 and updated the PR. |
brent-hoover
approved these changes
Aug 23, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4502
Impact: minor
Type: bugfix
Issue
When login/register was clicked without filling username and password the spinner runs forever.
email.trim()was being called without putting a null check on email and email was passed on as null.Solution
Added null check before calling
email.trim(). This causes the validation to fail in case of empty email.Breaking changes
None.
Testing