-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record plugin versions in DB and show in Shop panel #4895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See some minor comments
imports/plugins/core/dashboard/client/components/plugin-versions.js
Outdated
Show resolved
Hide resolved
imports/plugins/core/dashboard/client/containers/plugin-versions.js
Outdated
Show resolved
Hide resolved
import PropTypes from "prop-types"; | ||
import PluginVersion from "../components/plugin-versions"; | ||
|
||
class PluginVersionsContainer extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In new code we name the file the same as the component, in the same case: PluginVersionsContainer.js
imports/plugins/core/dashboard/client/components/plugin-versions.js
Outdated
Show resolved
Hide resolved
imports/plugins/core/dashboard/client/templates/shop/settings/settings.js
Show resolved
Hide resolved
Also there is one eslint error in |
@aldeed That "block style" rule totally bothers me as I feel like it forces me to make the code more difficult to read. C'est la vie. All changes addressed. |
Added a version to a plugin and it showed up. 👍 |
Resolves #4874
Impact: minor
Type: feature
Issue
Have some standard way to record versions of plugins and make them visible to an admin so that you know what code is deployed
Solution
Plugins can add a "version" key to
register.js
and they will be stored in the db and displayed in the shop panelBreaking changes
None
Testing
register.js
that looks like this: