feat: Add flag to enable only IDP routes #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impactmass
changed the title
impactmass
force-pushed
the
feat-4852-impactmass-router-and-idp
branch
from
1878195 to
e4762ac
Compare
impactmass
commented
Jan 9, 2019
| }, | ||
| description: "Not Found Page", | ||
| workflow: "hydraOauthLogin", | ||
| template: "notFound" |
There was a problem hiding this comment.
IDP's Not Found route definition. Here it's using the existing/default template. It can be updated to use a custom template as needed
| @@ -7,6 +7,6 @@ Hooks.Events.add("afterCoreInit", () => { | |||
| Reaction.addRolesToGroups({ | |||
| allShops: true, | |||
| groups: ["guest", "customer"], | |||
| roles: ["account/login"] | |||
| roles: ["account/login", "not-found"] | |||
There was a problem hiding this comment.
Since the IDP defines the Not Found registry route, it needs to grant the access to it.
impactmass
changed the title
impactmass
commented
Jan 10, 2019
| const query = { shopId: myShopId }; | ||
|
|
||
| // This is to ensure only needed Identity-provider-related routes are published | ||
| // The env can be one of three: "all", "idp-only", "exclude-idp". Default behavior is "all" |
There was a problem hiding this comment.
@ticean I added you for comments about the ENV values. Is the naming good, unambiguous etc?
mikemurray
approved these changes
Jan 11, 2019
|
@impactmass approved on my end. You're free to merge whenever you get the 👍 from @ticean. |
ticean
approved these changes
Jan 11, 2019
| const query = { shopId: myShopId }; | ||
|
|
||
| // This is to ensure only needed Identity-provider-related routes are published | ||
| // The env can be one of three: "all", "idp-only", "exclude-idp". Default behavior is "all" |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4852
Impact:
Type: feature
Issue
See #4852
Goals for this PR:
Solution Overview
IDENTITY_PROVIDER_MODEthat is used to filter published routesDetails
all)idp-only)exclude-idp)Breaking changes
None
Testing
Note: Make sure to remove existing
reactioncontainer after changing env value (e.g withdocker-compose downand then up again).Set IDENTITY_PROVIDER_MODE=all in your ENV.
Once app is started, we want to confirm that all routes are available. Home page should load the products and
/account/loginshould show login form.Set IDENTITY_PROVIDER_MODE=idp-only in your ENV.
Once app is started, we want to confirm that only IDP routes show. Viewing
/account/loginshould show login form. Other usual pages (including home page) show Not Found.Set IDENTITY_PROVIDER_MODE=exclude-idp in your ENV.
Once app is started, we want to confirm that IDP routes do not show. Viewing
/account/loginshould not show up. Other usual pages (including home page) should show.