fix: add replace to remove comma from formatting #4910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4900
Impact: minor
Type: bugfix
Issue
Price ranges that included a number above 1000 would show up as NAN in the admin Grid. This is due to the currency being formatted twice, which in turn adds double commas into the string, which breaks the display.
Solution
Use our "new"
getProductPriceRange
to calculate the price range based off ofmin
andmax
number
s, instead of the price rangestring
.Breaking changes
None
Testing