fix: add contentForLanguage resolver for nav item content #4913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4912
Impact: minor
Type: bugfix
Issue
The
NavigationItemData.content
resolver currently filters down the content array by the language argument provided to thenavigationTreeById
GraphQL query. Instead, it should return the array without filtering for the operator UI, and have a separate resolver that storefront can use to load the translated content string.Solution
This PR removes the filtering from the
content
resolver and adds acontentForLanguage
resolver that returns the content string in the correct language. If a translation for that language is not available, it defaults to the first content provided.Breaking changes
None
Testing
draftData
anddata
, add a translation to the array:contentForLanguage
returns the Spanish content.