Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Password reset page not found #4917

Merged
merged 4 commits into from
Jan 16, 2019

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Jan 14, 2019

Resolves #4911
Impact: major
Type: bugfix

Issue

Clicking on link in email sent when password reset is requested results in a 404.

Solution

This previous update enabled explicit checking for route item permissions. The reset password permission wasn't enabled for guest and customers, hence the 404 happens.

This PR, adds the route permission to users. It also updates the name to follow other defined plugin convention.

Breaking changes

N/A
A migration is added to update existing name to match this update.

Testing

  1. As an admin, enable and configure email settings (docs).
  2. Logout, then in the login dropdown, do a password reset
  3. Follow link in email
  4. Confirm that following the link in the email received shows the password reset form

@impactmass impactmass changed the title [WIP] Fix Password reset page not found Fix Password reset page not found Jan 14, 2019
@xtebs
Copy link

xtebs commented Jan 16, 2019

I tested and its working :) Thanks! 👍

ps:
roles: ["account/verify", ENROLLL, "reset-password"] (on init.js) it will be the correct way, in order to work also with "fix-4892-impactmass-invite-404"

@impactmass impactmass force-pushed the fix-4911-impactmass-resetpass-404 branch from a9e5d85 to 91e2689 Compare January 16, 2019 14:24
@impactmass impactmass self-assigned this Jan 16, 2019
Copy link
Contributor

@dancastellon dancastellon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@impactmass impactmass merged commit cbae839 into develop Jan 16, 2019
@impactmass impactmass deleted the fix-4911-impactmass-resetpass-404 branch January 16, 2019 18:56
@spencern spencern mentioned this pull request Jan 18, 2019
@impactmass impactmass mentioned this pull request Jan 22, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants