Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix sitemaps test timeouts #4920

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Conversation

impactmass
Copy link
Contributor

Impact: minor
Type: test
Related: #4909

Issue

The generateSitemaps Meteor app tests often fail with a timeout error on CI.

Solution

Increase timeout.

Breaking changes

None

Testing

Verify the app-test build phase succeeds on CI.

@impactmass impactmass force-pushed the fix-impactmass-test-timeouts branch from aa7624d to 23c3f67 Compare January 16, 2019 11:52
Copy link
Contributor

@dancastellon dancastellon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dancastellon dancastellon merged commit 3e4ada0 into develop Jan 16, 2019
@impactmass impactmass deleted the fix-impactmass-test-timeouts branch January 16, 2019 15:43
@spencern spencern mentioned this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants