Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixes for product editor #6141

Merged
merged 4 commits into from
Mar 4, 2020
Merged

feat: Fixes for product editor #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78ab194
feat: update translations
mikemurray Mar 4, 2020
f183b0c
feat: add shouldAppearInSitemap field
mikemurray Mar 4, 2020
bdae08a
feat add shouldAppearInSitemap field
mikemurray Mar 4, 2020
a5e5795
Merge branch 'trunk' into feat-6114-mikemurray-product-gql
mikemurray Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core-services/product/mutations/updateProduct.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ const inputSchema = new SimpleSchema({
type: String,
optional: true
},
"shouldAppearInSitemap": {
willopez marked this conversation as resolved.
Show resolved Hide resolved
type: Boolean,
optional: true
},
"supportedFulfillmentTypes": {
type: Array,
optional: true
Expand Down
6 changes: 6 additions & 0 deletions src/core-services/product/schemas/product.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ type Product {
"The shop to which this product belongs"
shop: Shop!

"Whether this product will be shown in the generated sitemap"
shouldAppearInSitemap: Boolean

"A URL-safe and human-readable string that uniquely identifies this product"
slug: String

Expand Down Expand Up @@ -405,6 +408,9 @@ input ProductInput {
"An arbitrary product type value, such as from an external system"
productType: String

"Whether this product will be shown in the generated sitemap"
shouldAppearInSitemap: Boolean

"A URL-safe and human-readable string that uniquely identifies this product"
slug: String

Expand Down
13 changes: 11 additions & 2 deletions src/plugins/translations/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,9 @@
"shortcut": {
"addProductLabel": "Add product",
"accountsLabel": "Accounts"
}
},
"visible": "Visible",
"hidden": "Hidden"
},
"searchSettings": {
"productSearchSettings": {
Expand Down Expand Up @@ -443,6 +445,7 @@
"archiveThisProduct": "Archive this product?",
"archiveSelectedProducts": "Archive selected products?",
"publish": "Publish",
"published": "Published",
"moreOptions": "More Options",
"details": "Details",
"noSelectedProducts": "No selected products. Use the ",
Expand All @@ -460,6 +463,7 @@
"addVariantOptions": "Add options to enable 'Add to Cart' button",
"title": "Title",
"price": "Price",
"prices": "Prices",
"optionTitle": "Short title",
"barcode": "Barcode",
"compareAtPrice": "Compare at price",
Expand All @@ -472,7 +476,12 @@
"taxCode": "Tax code",
"taxDescription": "Tax description",
"originCountry": "Origin country",
"selectTaxCode": "Select tax code"
"selectTaxCode": "Select tax code",
"updateVariantSuccess": "Product variant updated successfully",
"updateVariantFail": "Unable to update product variant",
"updateVariantPricesSuccess": "Variant Prices updated successfully",
"updateVariantPricesFail": "Unable to update variant prices",
"pricePublishWarning": "Changes to prices are published on save"
},
"variantList": {
"moreOptions": "There are more options available for this selection.",
Expand Down