refactor: move i18n service to npm #6193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
kieckhafer
requested changes
Apr 14, 2020
Signed-off-by: Maria Paktiti <[email protected]>
mpaktiti
commented
Apr 14, 2020
| @@ -9,6 +9,7 @@ const externalNodeModules = [ | |||
| "@reactioncommerce/api-plugin-accounts", | |||
| "@reactioncommerce/api-plugin-address-validation", | |||
| "@reactioncommerce/api-plugin-address-validation-test", | |||
| "@reactioncommerce/api-plugin-i18n", | |||
There was a problem hiding this comment.
@kieckhafer should I also move lines 7+8 under the api-plugin-i18n or they are left there for a reason?
Signed-off-by: Erik Kieckhafer <[email protected]>
37 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6173
This PR removes the internal
i18nservice and installs the new api-plugin-i18n npm package as its replacement.The code in this npm package is the same, and has already been tested, so the expected outcome of this PR is seeing nothing different than how the app currently runs.
Signed-off-by: Maria Paktiti [email protected]