Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: corrected promotion removal message #6811 #6858

Closed
wants to merge 1 commit into from
Closed

Fix typo: corrected promotion removal message #6811 #6858

wants to merge 1 commit into from

Conversation

rishabhdwivedii
Copy link

Resolves #6811
Impact: minor
Type: bugfix

Issue

Message says "The promotion no longer available", should say "Promotion is no longer available". Also not sure that requiresReadAcknowledgement should be set to true on this.

Solution

  1. Changed the message from "The promotion no longer available" to "Promotion is no longer available" in packages/api-plugin-promotions/src/handlers/applyPromotions.js and packages/api-plugin-promotions/src/handlers/applyPromotions.test.js.
  2. Added requiresReadAcknowledgement: true to this message in packages/api-plugin-promotions/src/handlers/applyPromotions.js

Breaking changes

None

Testing

  1. Changed expect(cart.messages[0].title).toEqual("The promotion no longer available"); to expect(cart.messages[0].title).toEqual("Promotion is no longer available");
  2. Can add expect(cart.messages[0].requiresReadAcknowledgement).toEqual(true); in packages/api-plugin-promotions/src/handlers/applyPromotions.test.js to test whether requiresReadAcknowledgement is set to true or not.

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: 259c14f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rishabhdwivedii rishabhdwivedii closed this by deleting the head repository Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in promotion removal message
1 participant