Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typo in applyPromotion.test.js and applyPromotions.js of promotion #6861

Closed
wants to merge 2 commits into from

Conversation

asharan2511
Copy link

Resolves #6811
Impact: minor
Type: bug

Issue

The message says that there is Typo error which needs to be changed from "The promotion no longer available" to "Promotion is no longer available".

Solution

successfully corrected the typo as mentioned in the bug description in the following paths
1.packages\api-plugin-promotions\src\handlers\applyPromotions.test.js
2.packages\api-plugin-promotions\src\handlers\applyPromotions.js

Breaking changes

NA

Testing

1.Changed expect(cart.messages[0].title).toEqual("The promotion no longer available"); to expect(cart.messages[0].title).toEqual("Promotion is no longer available");
2.Can add expect(cart.messages[0].requiresReadAcknowledgement).toEqual(true); in packages/api-plugin-promotions/src/handlers/applyPromotions.test.js to test whether requiresReadAcknowledgement is set to true or not.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

⚠️ No Changeset found

Latest commit: e516b71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asharan2511 asharan2511 closed this Oct 9, 2023
@asharan2511 asharan2511 deleted the fix/typo-6811 branch October 9, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in promotion removal message
1 participant