Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label checks can produce false failures #48

Closed
kloots opened this issue Jun 8, 2015 · 1 comment
Closed

Label checks can produce false failures #48

kloots opened this issue Jun 8, 2015 · 1 comment

Comments

@kloots
Copy link
Collaborator

kloots commented Jun 8, 2015

I introduced a logic error in 0.2.0. When the child is a component, hasChildTextNode() uses a componentDidMount listener to check the DOM of the rendered component. However, after binding the componentDidMount listener, hasChildTextNode() returns undefined, resulting in the error handler being called prematurely. To fix this hasChildTextNode() should return true in this case.
kloots pushed a commit that referenced this issue Jun 8, 2015
[fixed] bug where the label assertion can return a false failure #48
8c6a7ce
angus-c added a commit that referenced this issue Jun 8, 2015
@angus-c
Merge pull request #49 from rackt/fix-label-false-failure
d329393 
[fixed] bug where the label assertion can return a false failure #48
@kloots
Copy link
Collaborator Author

kloots commented Jun 8, 2015

Fixed in 0.2.1

@kloots kloots closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kloots